Make line-numbers styles more specific#1434
Merged
mAAdhaTTah merged 1 commit intogh-pagesfrom Jun 3, 2018
Merged
Conversation
The padding added to `pre.line-numbers` in the line-number's CSS is overwritten by the theme's CSS if the theme is loaded second. This ensures the CSS can come in any order without specificity issues.
Contributor
|
Wow, good catch. It does not happen on the website because we switch the theme "in place" so the order is kept. Looks good to me! |
Member
Author
|
So this introduces a bug in the Coy theme unless the CSS is loaded in reverse, because Coy moves the padding to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The padding added to
pre.line-numbersin the line-number's CSS isoverwritten by the theme's CSS if the theme is loaded second. This
ensures the CSS can come in any order without specificity issues.
I ran into this problem in the settings page for WP-Gistpen, where the
user can toggle the theme and enabled plugins. Switching between themes
removes the CSS for the previous theme from the head and injects the new
theme into the head, so the line-numbers CSS actually appears in the
head first. The theme CSS that sets the padding uses
prewhile theline-numbers
pre.line-numbers, and who "wins" is whomevercomes second.
There's also some whitespace cleanup here as well.
I think this is unlikely to be a breaking change, but interested in feedback on this.