Rename filesystem-provider example dir to avoid mcp/ collision#3878
Merged
Rename filesystem-provider example dir to avoid mcp/ collision#3878
Conversation
marvin-context-protocol
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FileSystemProviderquickstart example tells users to name their components directorymcp/, which collides with the installedmcpSDK package — if a user ever adds__init__.pyto that directory, Python's import resolution breaks and FastMCP's own imports start failing with errors likeImportError: cannot import name 'McpError' from 'mcp'. Context: #3812.Rather than adding a warning about a footgun we ship, this renames the example directory (and all its doc references) to
components/. No new guidance needed — the example just stops leading people into the collision.