fix: don't pass HTTP kwargs when transport is unspecified#3838
Merged
Conversation
marvin-context-protocol
Bot
added
bug
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d14193ebcd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When transport is None (the default), run_async resolves it to settings.transport which defaults to "stdio". The previous guard `transport != "stdio"` passed HTTP kwargs through for None transport, causing TypeError in run_stdio_async. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
strawgate
force-pushed
the
fix/run-command-stdio-kwargs
branch
from
d14193e to
95b3a68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3833. When
transportisNone(the default),run_asyncresolves it tosettings.transportwhich defaults to"stdio". The guard from #3833 usedtransport != "stdio"which isTrueforNone, so HTTP-specific kwargs likeport=0leaked intorun_stdio_asyncand causedTypeError.The fix resolves the effective transport from
fastmcp.settings.transportbefore deciding which kwargs to forward.Fixes #3844
🤖 Generated with Claude Code