Fix CIMD clients getting required_scopes instead of valid_scopes#3836
Merged
Fix CIMD clients getting required_scopes instead of valid_scopes#3836
Conversation
marvin-context-protocol
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a CIMD client (like Claude Code) connects to an OAuthProxy with both
required_scopesandvalid_scopesconfigured, it gets registered with onlyrequired_scopes. This happens because CIMD clients bypass theRegistrationHandler(which appliesvalid_scopesviaClientRegistrationOptions), and the_default_scope_strfallback was built fromrequired_scopesalone. Any authorization request for a scope beyond the required set gets rejected withinvalid_scopebefore it ever reaches the upstream IdP.The fix is a one-line change:
_default_scope_strnow prefersvalid_scopes, matching the logic already used when constructingClientRegistrationOptions.Closes #3828