fix: accept both client_id and identifier_uri as Azure audience#3797
Merged
fix: accept both client_id and identifier_uri as Azure audience#3797
Conversation
…oken validation Azure AD v2 tokens set `aud` to the bare client ID, while v1 tokens use the Application ID URI. Accept both so validation works regardless of `accessTokenAcceptedVersion`. Fixes #3796
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3787 fixed audience validation for custom
identifier_urivalues (likeapi://my-app-namefrom Bicep deployments) by switching fromaudience=client_idtoaudience=identifier_uri. But this broke the default case: whenidentifier_uriis the defaultapi://{guid}, Azure AD v2 tokens setaudto the bare GUID, not theapi://form — so every token got rejected.The fix accepts both formats as valid audiences, which
JWTVerifieralready supports natively. This is safe because both values are identifiers for the same Azure app registration — client IDs are GUIDs and can't collide with URI-format identifier URIs.Fixes #3796