fix: use explicit None checks for JWT exp validation#3724
Merged
Conversation
The exp checks used Python truthiness (`if exp and ...`, `if exp else`) which silently passes when exp is 0 or missing.
jlowin
added
the
bug
marvin-context-protocol
Bot
added
the
auth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JWT expiration checks in
jwt_issuer.py,providers/jwt.py, andproviders/introspection.pyused Python truthiness (if exp and exp < time.time()) instead of explicit None checks. This meantexp=0would silently skip the expiration check rather than correctly treating it as expired.Same issue affected
expires_atassignment (int(exp) if exp else None) which would discard a legitimateexp=0value.