Skip to content

fix(google): use sub (user ID) for client_id instead of aud (app ID)#3722

Merged
jlowin merged 1 commit intoPrefectHQ:mainfrom
shigechika:fix/google-client-id-sub
Mar 31, 2026
Merged

fix(google): use sub (user ID) for client_id instead of aud (app ID)#3722
jlowin merged 1 commit intoPrefectHQ:mainfrom
shigechika:fix/google-client-id-sub

Conversation

@shigechika
Copy link
Copy Markdown
Contributor

Fixes #3721

GoogleProvider sets client_id=aud (OAuth app ID), which is the same for all users. Multi-user servers can't distinguish users. GitHubProvider already uses the user ID.

Changed client_id=audclient_id=sub and updated tests.

@marvin-context-protocol marvin-context-protocol Bot added bug Something isn't working. Reports of errors, unexpected behavior, or broken functionality. auth Related to authentication (Bearer, JWT, OAuth, WorkOS) for client or server. breaking change Breaks backward compatibility. Requires minor version bump. Critical for maintainer attention. labels Mar 31, 2026
Copy link
Copy Markdown
Member

@jlowin jlowin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlowin jlowin merged commit 5be249a into PrefectHQ:main Mar 31, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth Related to authentication (Bearer, JWT, OAuth, WorkOS) for client or server. breaking change Breaks backward compatibility. Requires minor version bump. Critical for maintainer attention. bug Something isn't working. Reports of errors, unexpected behavior, or broken functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GoogleProvider: client_id uses OAuth app ID (aud) instead of user ID (sub)

2 participants