Skip to content

Forward enable_cimd to OAuthProxy in all provider subclasses#3608

Merged
jlowin merged 1 commit intomainfrom
enable-cimd-providers
Mar 24, 2026
Merged

Forward enable_cimd to OAuthProxy in all provider subclasses#3608
jlowin merged 1 commit intomainfrom
enable-cimd-providers

Conversation

@jlowin
Copy link
Copy Markdown
Member

@jlowin jlowin commented Mar 24, 2026

OAuthProxy accepts enable_cimd to control CIMD (Client ID Metadata Document) support, but none of the concrete provider subclasses exposed it — so the only way to disable CIMD was reaching into private internals after construction.

This adds enable_cimd: bool = True to the __init__ of AzureProvider, GitHubProvider, GoogleProvider, DiscordProvider, and WorkOSProvider, forwarding it through to super().__init__(). (OIDCProxy already had it.)

auth = AzureProvider(
    client_id="...",
    client_secret="...",
    tenant_id="...",
    required_scopes=["read"],
    base_url="http://localhost:8000",
    enable_cimd=False,  # now works
)

Closes #3602

@jlowin jlowin added enhancement Improvement to existing functionality. For issues and smaller PR improvements. auth Related to authentication (Bearer, JWT, OAuth, WorkOS) for client or server. labels Mar 24, 2026
@jlowin jlowin merged commit 7c98326 into main Mar 24, 2026
8 checks passed
@jlowin jlowin deleted the enable-cimd-providers branch March 24, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth Related to authentication (Bearer, JWT, OAuth, WorkOS) for client or server. enhancement Improvement to existing functionality. For issues and smaller PR improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure Provider could forward some parameters to OAuthProxy, eg to disable CIMD

1 participant