Skip to content

Claude/review contributor guidelines#3517

Merged
jlowin merged 3 commits intomainfrom
claude/review-contributor-guidelines-GgGrg
Mar 15, 2026
Merged

Claude/review contributor guidelines#3517
jlowin merged 3 commits intomainfrom
claude/review-contributor-guidelines-GgGrg

Conversation

@jlowin
Copy link
Copy Markdown
Member

@jlowin jlowin commented Mar 15, 2026

No description provided.

@marvin-context-protocol marvin-context-protocol Bot added enhancement Improvement to existing functionality. For issues and smaller PR improvements. tests labels Mar 15, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dce3367573

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +102 to +103
WHEN APPLYING too-long: After labeling, post a brief comment using mcp__github__add_issue_comment:
"Thanks for the report. This issue goes beyond what our contributor guidelines ask for — we just need a short problem description and an MRE. Please see [our pinned guidelines](https://github.com/PrefectHQ/fastmcp/issues/3506) and condense this issue. We'll triage it once it's trimmed down."
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Resolve conflicting comment instructions in triage prompt

This new too-long branch instructs Marvin to post a comment via mcp__github__add_issue_comment, but the same prompt still ends with a blanket DO NOT post any comments rule in step 4. In the too-long scenario, these contradictory directives can cause the model to apply the label without posting the required guidance, leaving contributors without the condense instructions and stalling retriage. Make the final no-comment rule explicitly exempt too-long cases so behavior is consistent.

Useful? React with 👍 / 👎.

@jlowin jlowin merged commit 93753e1 into main Mar 15, 2026
7 checks passed
@jlowin jlowin deleted the claude/review-contributor-guidelines-GgGrg branch March 15, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement to existing functionality. For issues and smaller PR improvements. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants