Add security label to triage workflow and release notes#3516
Merged
Conversation
jlowin
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a wave of security-related PRs (SSRF, path traversal, auth bypass, scope escalation), we had no way to distinguish them from ordinary bug fixes in triage or release notes.
This adds a
securitylabel to the Marvin triage workflow with guidance that draws a clear line between exploitable vulnerabilities and regular auth/correctness bugs — the key question being "could a malicious actor exploit this?" rather than "does this break for legitimate users."The release notes template gets a new Security 🔒 section (after Enhancements, before Fixes), with exclusion rules so security PRs don't also appear under Fixes, Enhancements, or Dependencies. Also moves Breaking Changes up to second position (after Features) and freshens up a couple emoji choices.