fix: enforce per-tool auth checks in sampling tool wrapper#3494
Merged
Conversation
Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
SamplingTool.from_callable_tool()wraps aFunctionToolorTransformedToolfor use in sampling contexts (ctx.sample/ctx.sample_step), the generated wrapper callstool.run()directly without running the tool'sauthchecks. The server's HTTP dispatcher appliesrun_auth_checksbefore every tool call, but the sampling wrapper bypassed this entirely -- creating a privilege escalation path where an LLM could invoke auth-protected tools through sampling without proper authorization.The fix adds the same auth enforcement logic inside the
from_callable_toolwrapper that the server dispatcher uses: checktool.auth, resolve the current transport and access token, and runrun_auth_checksbefore delegating totool.run(). STDIO transport skips auth checks as it does everywhere else. A tool withoutauthset is unaffected.Co-authored-by: Claude [email protected]