Guard default progress handler against total=0 notifications#3432
Merged
Guard default progress handler against total=0 notifications#3432
Conversation
🤖 Generated with GPT-5.2-Codex
Member
Author
|
Auto-reviewed and merging on behalf of @jlowin — CI is green (Windows OAuth proxy timeouts are pre-existing flaky tests). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
total=0, which could be abused by an untrusted or buggy server to abort tool execution.Description
default_progress_handlerto only compute a percentage whentotal not in (None, 0)and add anelif total == 0branch that logs the rawprogress/totalstring without dividing, and addtest_default_progress_handler_handles_zero_totaltotests/client/test_progress.pyto cover the case.Testing
uv sync(succeeded), ran the full suite withuv run pytest -n auto(the repository-wide run reported unrelated failures/timeouts), ranuv run pytest tests/client/test_progress.py(4 passed), and attempteduv run prek run --all-fileswhich failed to initialize hooks due to external network access tocodespell(403).Codex Task