Split large test files to comply with loq line limit#3328
Conversation
All 13 test files that exceeded 1000 lines have been split into smaller files, preserving all tests. loq.toml cleaned up to remove stale exceptions for files that no longer exist. https://claude.ai/code/session_0174t6BGpdDCiwqULpizGU2E
marvin-context-protocol
Bot
added
enhancement
Test Failure AnalysisSummary: The Root Cause: Running Suggested Solution: Run Detailed Analysisruff check (FAILED)Ruff auto-fixed 20 lint errors, but since it modified files in CI, the hook still fails. ruff format (FAILED)Files with issues
Related Files
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c0eb65d26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| from fastmcp import FastMCP | ||
| from fastmcp.client import Client | ||
| from fastmcp.dependencies import CurrentContext, Depends |
There was a problem hiding this comment.
This new module keeps Depends at top level even though no test in the file uses that binding anymore, and several tests re-import Depends locally; under the repo's Ruff config this produces F401/F811 and causes the required static check step to fail (ruff check passes on the parent commit but fails after this change). Because CI expects lint to be clean before merge, this blocks the workflow until these stale imports are removed (the same pattern appears in other newly split test files as well).
Useful? React with 👍 / 👎.
2 participants
Several test files had grown beyond the 1000-line threshold enforced by loq, causing CI failures. This splits 13 oversized files into 27 smaller focused files, each under the limit, with no tests removed or modified.
Each original file retains its existing tests; extracted tests move to a companion file named for their subject (e.g.
test_sampling.py→test_sampling_tool_loop.py+test_sampling_result_types.py).loq.tomlis cleaned up to remove stale exceptions for files that no longer exist.🤖 Generated with Claude Code
https://claude.ai/code/session_0174t6BGpdDCiwqULpizGU2E