fix: stop suppressing server stderr in fastmcp call#3283
Merged
Conversation
Server subprocess stderr was being sent to /dev/null, which silently discarded print(..., file=sys.stderr) and logging output from tools.
marvin-context-protocol
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastmcp callwas sending server subprocess stderr to/dev/null, which meant anyprint(..., file=sys.stderr)or logging output from tool functions was silently discarded. This made print-debugging impossible when using stdio transport.The fix removes the explicit
/dev/nullredirect, letting stderr flow through to the terminal as expected.print()to stdout is still consumed by the JSON-RPC protocol on stdio (that's inherent to the transport), but stderr debugging now works.Closes #3278