Fix NameError with future annotations and Context/Depends parameters#3243
Merged
Fix NameError with future annotations and Context/Depends parameters#3243
Conversation
Pydantic (even 2.11.7) uses __module__ not __globals__ to resolve annotations, so setting __module__ alone is sufficient.
The wrapper's __globals__ is read-only and points to dependencies.py, so some Pydantic versions use it instead of __module__ when resolving string annotations. Pre-resolving via get_type_hints on the original function ensures annotations are type objects before Pydantic sees them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tool uses
from __future__ import annotationsand has aContextorDepends()parameter,without_injected_parameterscreates a wrapper function to strip those params before Pydantic processes the signature. But the wrapper inherited__module__ = 'fastmcp.server.dependencies'instead of the user's module. Pydantic resolves string annotations (which is what future annotations produces) viasys.modules[fn.__module__].__dict__— so it was looking in the wrong namespace and failing withNameErrorfor any type not imported bydependencies.pyitself (Annotated,Literal, user-defined types, etc.).The fix sets
wrapper.__module__andwrapper.__qualname__from the original function so Pydantic resolves annotations against the user's module where the names actually exist.Closes #3238, closes #905