feat(core): single registerSingleton to avoid duplication#17
Merged
rieckpil merged 1 commit intoPragmaTech-GmbH:mainfrom Aug 11, 2025
Merged
Conversation
seregamorph
force-pushed
the
singleton-registration
branch
from
d6c85b3 to
44ae9a2
Compare
|
seregamorph
commented
Aug 10, 2025
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object that) { |
Contributor
Author
There was a problem hiding this comment.
alternatively, this could be implemented as
if (!applicationContext.getBeanFactory().containsSingleton(BEAN_CONTEXT_DIAGNOSTIC)) {
applicationContext
.getBeanFactory()
.registerSingleton(BEAN_CONTEXT_DIAGNOSTIC, completedDiagnostic);
}but this solution with equals looks as a proper solution
seregamorph
changed the title
rieckpil
changed the title
Contributor
|
good catch, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a scenario when
ContextDiagnosticApplicationInitializeris specified in bothspring.factoriesdiscovered in the classpath and specified explicitly on the class. In this case test execution fails withand this failure is pretty unclear as test eventually fails with other diagnostics (if the suite is heavy and big). This simple fix makes the singleton registration conditional to do it not more than once.