Skip to content

Add Get-StringHash#63

Merged
SteveL-MSFT merged 3 commits intoPowerShell:masterfrom
iSazonov:master
Feb 2, 2017
Merged

Add Get-StringHash#63
SteveL-MSFT merged 3 commits intoPowerShell:masterfrom
iSazonov:master

Conversation

@iSazonov
Copy link
Copy Markdown
Contributor

@iSazonov iSazonov commented Jan 27, 2017

Introduce new cmdlet - Get-StringHash.

Author of the idea @rkeithhill PowerShell/PowerShell#2731
Related PR PowerShell/PowerShell#3024


This change is Reviewable

@msftclas
Copy link
Copy Markdown

Hi @iSazonov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@splatteredbits
Copy link
Copy Markdown

I love this idea.

Is Get the right verb? I usually only use the Get verb if there is an identical command I can pair with it that uses the Set verb, e.g. Get-Service, Set-Service. Since you don't set hashes, I think one of the following command names might be better:

  • ConvertTo-Hash
  • New-Hash
  • Convert-StringToHash
  • Measure-Hash

According to the Approved Verbs page, New should be used instead of "Create, Generate, Build, Make, or Allocate." Measure maps to "Calculate". I looked for a verb that was synonymous with "Compute", but didn't find one.

@iSazonov
Copy link
Copy Markdown
Contributor Author

iSazonov commented Jan 27, 2017

Get is because we already have Get-FileHash.

Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the box to allow maintainers to edit the PR so we can add the RFC##. Thanks.

@iSazonov
Copy link
Copy Markdown
Contributor Author

iSazonov commented Feb 2, 2017

@SteveL-MSFT Fixed!

@SteveL-MSFT SteveL-MSFT merged commit d6fc54f into PowerShell:master Feb 2, 2017
@SteveL-MSFT
Copy link
Copy Markdown
Member

@iSazonov please open an issue for feedback on this RFC (look at the previous ones as an example) that way you get notified if someone comments. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants