Draft of PSModulePath behavior in PS7#233
Merged
joeyaiello merged 6 commits intoPowerShell:masterfrom Feb 5, 2020
Merged
Conversation
14 tasks
vexx32
reviewed
Nov 12, 2019
14 tasks
Contributor
JamesWTruher
left a comment
JamesWTruher
left a comment
There was a problem hiding this comment.
I think it's good, but some details still need fleshing out
1-Draft/RFCxxxx-PSModulePath.md
Outdated
|
|
||
| ### Starting PowerShell 7 from Windows PowerShell | ||
|
|
||
| The PowerShell 7 startup covers this case and should just work. |
Contributor
There was a problem hiding this comment.
these need to be explicit; what changes are made (if any) to env:PSModulePath in these cases? Are there differences between platforms (Windows vs Non-Windows)
SteveL-MSFT
commented
Jan 29, 2020
1-Draft/RFCxxxx-PSModulePath.md
Outdated
| Change would be to use `$env:PSModulePath`, but prefix with `User` modules path + `System` modules path + | ||
| `$PSHOME` modules path if any of those paths are not already there. | ||
|
|
||
| `Windows` modules path will already be there along with any additional paths added by the user or applications. |
Member
Author
There was a problem hiding this comment.
Update to reflect the comparison with PSModulePath in User registry
SteveL-MSFT
commented
Jan 29, 2020
1-Draft/RFCxxxx-PSModulePath.md
Outdated
|
|
||
| ### Starting Windows PowerShell from PowerShell 7 | ||
|
|
||
| ```powershell |
sdwheeler
requested changes
Jan 29, 2020
1-Draft/RFCxxxx-PSModulePath.md
Outdated
|
|
||
| ### Starting Windows PowerShell from PowerShell 7 | ||
|
|
||
| ```powershell |
Collaborator
There was a problem hiding this comment.
Unindent these code blocks. The MD code fences are being treated as code because of the indentation. This causes a rendering problem
11 tasks
Fix examples to be consistent.
sdwheeler
approved these changes
Jan 30, 2020
Contributor
|
@PowerShell/powershell-committee has accepted this RFC, and it's been implemented in PS 7.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define behavior of PSModulePath in PS7 when starting and when starting Windows PowerShell