-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Publish global tool packages to pwshtool blob and bug fixes #9163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adityapatwardhan
merged 5 commits into
PowerShell:master
from
adityapatwardhan:FixGlobalToolPackage
Mar 20, 2019
Merged
Publish global tool packages to pwshtool blob and bug fixes #9163
adityapatwardhan
merged 5 commits into
PowerShell:master
from
adityapatwardhan:FixGlobalToolPackage
Mar 20, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@TravisEz13 The PR is ready for review. |
TravisEz13
requested changes
Mar 19, 2019
Member
Author
|
@TravisEz13 - Addressed your comments. Please re-review. |
TravisEz13
approved these changes
Mar 19, 2019
Member
Author
|
Do not merge. More changes coming. |
PaulHigin
approved these changes
Mar 20, 2019
TravisEz13
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9148
PR Summary
Publish global tool packages to a difference storage account. Also fix issues in removing unnecessary runtimes. Also added debug statements.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests