What is the motivation for making these types public? For example, I believe PSRemotingJob was meant for internal implementation and only its base class Job was meant for public use.

I'm not totally sure I understand the motivation - maybe an upcoming change in the CLR?

I haven't reviewed the changes closely, but after a quick glance, if a CLR change forces these types to be public, I'd move them to an Internal namespace to make it clear they are implementation details, and probably add an Obsolete attribute to discourage/disallow their use in other assemblies.

@lzybkr - We are planning to use GenAPI to build reference assemblies. These types are not found when compiling the generated .cs file, as they are marked as internal. I believe all of them should be marked as public, hence the change.

I see. I'm assuming that custom attributes are always included in the reference assembly just in case a build tool like the C# compiler needs to see the attribute to generate correct code or check for errors.

I'm not aware of any build tool that needs to see PowerShell's attributes, so I would expect careful thought before blindly making these types public.

Many of the names are not good public apis - they maybe sound too general, e.g.

• ArgumentToVersionTransformationAttribute is quite specific and special w.r.t. PowerShell versions
• ValidateVariableName is missing the Attribute suffix and validates in a very specific way that is not as general as the name suggests.
• ArgumentToModuleTransformationAttribute sounds promising and useful, yet it's only used in one place in PowerShell - so maybe it's not really that useful.

I wonder if EnumMultipleTypeConverter needs to be applied as an attribute at all - it's applied on types that are also Flags, so it's sort of ambiguous - should the conversion produce a single value or multiple values. If that could be removed, then maybe you can avoid exposing the Enum*TypeConverter types.

EnumSingleTypeConverter and EnumMultipleTypeConverter - classes had public methods

Having public methods doesn't seem to be a strong argument to make them public. We have other internal types with public modifier applied to its methods or properties. These 2 types are not attributes, so how are they exposed by GenApi?

If GenAPI doesn't work because the types is visible externally it is GenAPI problem and it would be fixed in GenAPI. Or we could create a workaround on PowerShell to resolve the problem.

I will shortly add a gist of the .cs file generated by GenAPI.

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

This PR has been automatically closed because it is stale. If you wish to continue working on the PR, please first update the PR, then reopen it.
Thanks again for your contribution.
Community members are welcome to grab these works.