Skip to content

Fix Get-ChildItem -Path with wildcard char #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kwkam wants to merge 1 commit into from
Closed

Fix Get-ChildItem -Path with wildcard char #7403

kwkam wants to merge 1 commit into from

Conversation

@kwkam
Copy link
Contributor

@kwkam kwkam commented Jul 30, 2018 •
edited
Loading

PR Summary

Unescape non-literal, non-glob path before existence checking.
This solve the issue where Get-GhildItem does not behave correctly
when -Path contains special characters. For example,

Get-ChildItem -Path './`[dir`]'

will complain with error "Cannot find path ..." while

Get-ChildItem -Path './`[dir`]' -Depth 0

will work fine.

PR Checklist

@kwkam
[Feature] Fix Get-ChildItem -Path with wildcard char
ba213c1 
Unescape non-literal, non-glob path before existence checking.
This solve the issue where Get-GhildItem does not behave correctly
when -Path contains special characters. For example,
> Get-ChildItem -Path './`[dir`]'
will complain with error "Cannot find path ..." while
> Get-ChildItem -Path './`[dir`]' -Depth 0
will work fine.
@kwkam kwkam mentioned this pull request Jul 30, 2018
Closed
11 tasks
@kwkam kwkam changed the title [Feature] Fix Get-ChildItem -Path with wildcard char Fix Get-ChildItem -Path with wildcard char Jul 31, 2018
@stale
Copy link

stale bot commented Aug 30, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Aug 30, 2018
@stale stale bot removed the Stale label Sep 9, 2018
@stale
Copy link

stale bot commented Oct 9, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Oct 9, 2018
@stale
Copy link

stale bot commented Oct 19, 2018

This PR has be automatically close because it is stale. If you wish to continue working on the PR, please first update the PR, then reopen it.
Thanks again for your contribution.
Community members are welcome to grab these works.

@stale stale bot closed this Oct 19, 2018
@kwkam
Copy link
Contributor Author

kwkam commented Nov 10, 2018

It seems that I cannot reopen this. Do I have to create a new PR?

@vexx32
Copy link
Collaborator

vexx32 commented Jan 2, 2019

@kwkam I believe if you submit a new commit to this branch it should allow you to reopen it / reopen automatically.

@kwkam
Copy link
Contributor Author

kwkam commented Jan 11, 2019

@vexx32 I have merged the latest master into this branch, but still there is no option for re-opening the PR. Maybe I do not have the permission to reopen my PR?

@vexx32
Copy link
Collaborator

vexx32 commented Jan 11, 2019

That's very strange... I guess you can just open a new PR from the same branch?

@kwkam kwkam mentioned this pull request Mar 31, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrucePay BrucePay Awaiting requested review from BrucePay

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kwkam @vexx32