Enable full symbols for windows #6853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus CodeCoverage for windows
…ied) in build.psm1
TravisEz13
changed the title
adityapatwardhan
requested changes
May 10, 2018
PowerShell.Common.props
Outdated
| <DebugType>full</DebugType> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition=" '$(Configuration)' == 'Release' And '$(IsWindows)' == 'true' "> |
build.psm1
Outdated
| Write-Verbose "Using configuration '$Configuration'" | ||
|
|
||
| $PowerShellDir = if ($Configuration -eq 'Linux') { | ||
| $PowerShellDir = if ($Environment.IsLinux -or $Environment.IsMacOS) { |
Member
There was a problem hiding this comment.
can we do -not $Environment.IsWindows here as we elsewhere. Non-blocking.
| <DebugType>full</DebugType> | ||
| </PropertyGroup> | ||
|
|
||
|
|
Member
Author
There was a problem hiding this comment.
We usually have a blank line between groups.
adityapatwardhan
approved these changes
May 10, 2018
PowerShell.Common.props
Outdated
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition=" '$(Configuration)' == 'Release' And '$(IsWindows)' == 'true' "> | ||
| <!-- Define non-windows, release configuratio properties --> |
Member
There was a problem hiding this comment.
typo configuratio -> configuration
TravisEz13
force-pushed
the
enbale_full_symbols_for_windows
branch
from
509f48c to
81c795c
Compare
TravisEz13
changed the title
Member
Author
|
I filed an issue with dotnet for the issue encountered with optimizing non-windows platforms: https://github.com/dotnet/corefx/issues/29700 |
4 tasks
11 tasks
iSazonov
reviewed
May 26, 2018
| <!-- Set-Date fails with optimize enabled in NonWindowsSetDate | ||
| Debugging the issues resolves the problem | ||
| --> | ||
| <Optimize>false</Optimize> |
Collaborator
There was a problem hiding this comment.
@TravisEz13 Should we set true because we fixed Set-Date?
Member
Author
There was a problem hiding this comment.
There is a tracking issue with all the steps: #6872 We still have some steps before we can change this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The main purpose of this was to enable full symbols for windows release build.
I discovered an additional issue when trying to fix this:
This PR addresses this my merging the Linux configuration into the release configuration and using a condition to add the build constant for unixUpdate: optimizing on mac and Linux cause crashes. An issue was filed to track this: https://github.com/dotnet/corefx/issues/29700
Before we merge, I should validate that the release build works for:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests