[release/v7.6] Improve ADO package build and validation across platforms #26532
Conversation
TravisEz13
added
the
CL-BuildPackaging
There was a problem hiding this comment.
Pull request overview
This PR backports improvements to ADO package build and validation for macOS packages from #26398 to the release/v7.6 branch. The changes standardize macOS package naming to use x64 instead of x86_64 for Intel architecture, fix artifact upload logic in Azure DevOps pipelines to properly handle multiple packages, add comprehensive package validation tests, and add diagnostic logging for Mariner/Azure Linux systems.
Key changes:
- Standardize macOS package naming convention to use
x64instead ofx86_64for compatibility - Fix Azure DevOps artifact upload to iterate over multiple pkg and tar.gz files instead of assuming a single file
- Add comprehensive Pester tests for macOS package structure and naming conventions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/packaging/packaging.psm1 | Whitespace cleanup and logic to rename x86_64 to x64 in package names |
| test/packaging/macos/package-validation.tests.ps1 | New comprehensive validation tests for macOS packages with naming convention checks |
| build.psm1 | CRITICAL ISSUES: Merge conflict marker left in code, duplicate lines, and invalid -Verbose parameter usage with Start-NativeExecution |
| .pipelines/templates/mac-package-build.yml | Fixed artifact upload to iterate over multiple packages instead of single selection |
| .github/workflows/macos-ci.yml | Updated test path to point to new location |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
microsoft-github-policy-service
bot
added
the
Review - Needed
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
adityapatwardhan
force-pushed
the
backport/release/v7.6/26398-e7bf5621b
branch
from
20ab374 to
717d548
Compare
3 participants
Backport of #26398 to release/v7.6
Triggered by @TravisEz13 on behalf of @TravisEz13
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Improves GitHub Actions workflow and Azure DevOps pipeline for macOS package builds by fixing artifact upload logic and standardizing package naming conventions.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Changes verified by running affected workflows. Confirmed artifact uploads work correctly with multiple pkg and tar.gz files using the new iteration loop. macOS package naming convention validated to use x64 instead of x86_64.
Risk
REQUIRED: Check exactly one box.
High risk as it modifies build infrastructure (Azure DevOps pipeline template and GitHub Actions workflow), but necessary to maintain build health on release branch. Changes have been validated in master for 2+ weeks without issues.
Merge Conflicts
One file had merge conflicts during cherry-pick (build.psm1): Resolved by accepting incoming changes which add
-Verboseflags to package manager commands for better diagnostics on Mariner/Azure Linux systems.