Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 11, 2025

PR Summary

Standardizes all template path references across the .pipelines folder to use absolute paths for consistency and clarity.

PR Context

Template references in .pipelines were using inconsistent path formats - some used absolute paths (/.pipelines/templates/*.yml@self), others used relative paths (../../*.yml@self, ../*.yml, or just filename). This PR standardizes all references to use absolute paths throughout.

Updated 8 files to use consistent absolute path format /.pipelines/templates/*.yml@self:

Template files:

  • .pipelines/templates/packaging/windows/package.yml
  • .pipelines/templates/mac-package-build.yml
  • .pipelines/templates/linux-package-build.yml
  • .pipelines/templates/nupkg.yml
  • .pipelines/templates/SetVersionVariables.yml
  • .pipelines/templates/compliance/apiscan.yml

Pipeline files:

  • .pipelines/PowerShell-vPack-Official.yml
  • .pipelines/MSIXBundle-vPack-Official.yml

Template references standardized:

  • SetVersionVariables.yml@self/.pipelines/templates/SetVersionVariables.yml@self
  • shouldSign.yml/.pipelines/templates/shouldSign.yml@self
  • cloneToOfficialPath.yml/.pipelines/templates/cloneToOfficialPath.yml@self
  • rebuild-branch-check.yml@self/.pipelines/templates/rebuild-branch-check.yml@self
  • set-reporoot.yml@self/.pipelines/templates/set-reporoot.yml@self
  • insert-nuget-config-azfeed.yml/.pipelines/templates/insert-nuget-config-azfeed.yml@self
  • ../../*.yml@self/.pipelines/templates/*.yml@self
  • ../*.yml/.pipelines/templates/*.yml@self
  • .pipelines/templates/*.yml@self/.pipelines/templates/*.yml@self

Addresses feedback from #26425.

PR Checklist


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Work in progress on template path fix in package.yml Use relative paths for template references in windows/package.yml Nov 11, 2025
Copilot AI requested a review from TravisEz13 November 11, 2025 22:29
@TravisEz13
Copy link
Member

@copilot this was supposed to standardize on use absolute paths

Copy link
Contributor Author

Copilot AI commented Nov 11, 2025

@copilot this was supposed to standardize on use absolute paths

Corrected. Standardized all template references across .pipelines folder to use absolute paths (/.pipelines/templates/*.yml@self).

Updated 8 files to ensure consistency:

  • Template files: windows/package.yml, mac-package-build.yml, linux-package-build.yml, nupkg.yml, SetVersionVariables.yml, compliance/apiscan.yml
  • Pipeline files: PowerShell-vPack-Official.yml, MSIXBundle-vPack-Official.yml

Commit: 40a470a

Copilot AI changed the title Use relative paths for template references in windows/package.yml Standardize template references to use absolute paths across .pipelines folder Nov 11, 2025
daxian-dbw
daxian-dbw previously approved these changes Nov 12, 2025
Base automatically changed from fix-rebuild-branch-check-template-path to master November 12, 2025 17:00
@TravisEz13 TravisEz13 dismissed daxian-dbw’s stale review November 12, 2025 17:00

The base branch was changed.

@TravisEz13 TravisEz13 marked this pull request as ready for review November 12, 2025 19:10
Copilot AI review requested due to automatic review settings November 12, 2025 19:10
@TravisEz13 TravisEz13 requested a review from a team as a code owner November 12, 2025 19:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes template path references across the .pipelines folder to consistently use absolute paths with the format /.pipelines/templates/*.yml@self, improving clarity and maintainability of the Azure Pipeline configurations.

  • Converts all relative template paths (../, ./, and bare filenames) to absolute paths
  • Ensures consistent @self suffix for all template references
  • Affects 7 files across template and pipeline configuration files

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.pipelines/templates/nupkg.yml Standardized 3 template references to use absolute paths
.pipelines/templates/mac-package-build.yml Standardized 4 template references to use absolute paths
.pipelines/templates/linux-package-build.yml Standardized 4 template references to use absolute paths
.pipelines/templates/compliance/apiscan.yml Standardized 2 template references from relative ../ paths to absolute paths
.pipelines/templates/SetVersionVariables.yml Standardized set-reporoot.yml reference to use absolute path
.pipelines/PowerShell-vPack-Official.yml Standardized SetVersionVariables.yml reference from .pipelines/templates/ to absolute path with leading /
.pipelines/MSIXBundle-vPack-Official.yml Standardized SetVersionVariables.yml reference from .pipelines/templates/ to absolute path with leading /

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Nov 20, 2025
@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review - Needed The PR is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants