Improve ADO package build and validation across platforms #26398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add verbose logging for package filtering in macOS build process - Fix architecture naming for macOS package compatibility (x64 -> x86_64) - Update macOS CI to use new package validation test location - Reorganize and enhance package validation tests with better error handling - Move validation tests from tools/packaging/releaseTests to test/packaging/macos
- Add verbose logging to Mariner package installation for better debugging - Display /etc/os-release content during installation for troubleshooting - Add makecache command before installing packages - Ensure dpkg-deb availability by installing azurelinux-repos-extended - Fix package installation command to use dpkg instead of pkg - Refactor package installation commands for clarity and efficiency
TravisEz13
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request improves macOS package naming consistency and fixes package manager command issues for Mariner/Azure Linux. The changes ensure macOS packages use "x64" instead of "x86_64" for Intel architecture naming, align with industry conventions, and add validation tests to prevent regression.
- Renamed macOS Intel packages from
x86_64tox64for consistency with industry standards - Fixed missing
installsubcommand for Mariner package manager commands - Added comprehensive test coverage for macOS package naming conventions
- Cleaned up trailing whitespace and removed obsolete packaging tool installation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/packaging/packaging.psm1 | Converts x86_64 to x64 in macOS package filenames; cleaned trailing whitespace throughout RPM, DEB, and macOS packaging sections |
| test/packaging/macos/package-validation.tests.ps1 | Added copyright header, new tests validating package naming convention (x64 vs x86_64), and cleaned trailing whitespace |
| build.psm1 | Fixed Mariner package manager commands missing install subcommand; added diagnostic logging for /etc/os-release |
| .pipelines/templates/windows-package-build.yml | Removed obsolete makeappx tool installation step |
| .pipelines/templates/mac-package-build.yml | Enhanced artifact upload logging and iteration; cleaned trailing whitespace |
| .github/workflows/macos-ci.yml | Updated test path from old location to new standardized location |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TravisEz13
added
the
CL-BuildPackaging
TravisEz13
force-pushed
the
gem-ado-fixes
branch
from
3973543 to
1ae7205
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
test/packaging/macos/package-validation.tests.ps1:86
- The comment mentions "x64 with hyphens" which is misleading. The actual distinction is between "x64" (no underscores) versus "x86_64" (with underscores). Consider updating the comment to clarify this is about avoiding underscores, not about hyphens. For example: "Intel x64 - note: x64 without underscores, not x86_64"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
daxian-dbw
approved these changes
Nov 7, 2025
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 7, 2025
6 tasks
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 25, 2025
9 tasks
adityapatwardhan
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 4, 2025
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to the macOS packaging process, focusing on standardizing package naming conventions, improving artifact upload logic, and enhancing test coverage and diagnostics. The changes ensure that macOS package files use the correct architecture naming (
x64instead ofx86_64), improve how multiple artifacts are uploaded, and add more robust testing and logging.macOS Package Naming and Generation:
New-MacOsDistributionPackageto usex64instead ofx86_64in package filenames for compatibility. (tools/packaging/packaging.psm1)Test Improvements and Relocation:
tools/packaging/releaseTests/macOSPackage.tests.ps1totest/packaging/macos/package-validation.tests.ps1for better organization. (test/packaging/macos/package-validation.tests.ps1)x86_64with underscores. (test/packaging/macos/package-validation.tests.ps1)CI and Pipeline Enhancements:
.github/workflows/macos-ci.yml).pkgand.tar.gzartifacts by iterating over all matching files, with added verbose logging for better traceability. (.pipelines/templates/mac-package-build.yml)Diagnostics and Bootstrap Improvements:
/etc/os-releasecontent and improved package installation commands for Mariner (Azure Linux) in the bootstrap script. (build.psm1)