-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix build to only enable ready-to-run for the Release configuration #26290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the build configuration to enable ready-to-run compilation only for Release builds, preventing debugging issues in Debug builds. Previously, ready-to-run was enabled for all configurations when AppDeployment was set to SelfContained, which made it impossible to debug the code in Debug configuration.
Key changes:
- Split the
AppDeploymentproperty group to separate ready-to-run settings from other self-contained deployment settings - Added a configuration condition to enable ready-to-run only when both
AppDeploymentisSelfContainedandConfigurationisRelease
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
marked for backport because I'm not sure how far back this bug was introduced. |
|
📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
|
Not applicable to 7.4 |
PR Summary
Fix build to only enable ready-to-run for the Release configuration.
Currently,
Start-PSBuildwill enable ready-to-run even for 'Debug' configuration, which makes it impossible to debug the code. This PR fixes it to only enable ready-to-run for Release configuration.