Skip to content

Conversation

@daxian-dbw
Copy link
Member

PR Summary

Fix build to only enable ready-to-run for the Release configuration.
Currently, Start-PSBuild will enable ready-to-run even for 'Debug' configuration, which makes it impossible to debug the code. This PR fixes it to only enable ready-to-run for Release configuration.

Copilot AI review requested due to automatic review settings October 23, 2025 17:07
@daxian-dbw daxian-dbw requested a review from a team as a code owner October 23, 2025 17:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the build configuration to enable ready-to-run compilation only for Release builds, preventing debugging issues in Debug builds. Previously, ready-to-run was enabled for all configurations when AppDeployment was set to SelfContained, which made it impossible to debug the code in Debug configuration.

Key changes:

  • Split the AppDeployment property group to separate ready-to-run settings from other self-contained deployment settings
  • Added a configuration condition to enable ready-to-run only when both AppDeployment is SelfContained and Configuration is Release

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 23, 2025
@TravisEz13
Copy link
Member

marked for backport because I'm not sure how far back this bug was introduced.

@daxian-dbw daxian-dbw merged commit b0507ca into PowerShell:master Oct 23, 2025
39 checks passed
@daxian-dbw daxian-dbw deleted the tab_fix branch October 23, 2025 18:21
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Oct 23, 2025

📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@TravisEz13
Copy link
Member

Not applicable to 7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Migrated BackPort-7.5.x-Consider Backport-7.6.x-Migrated CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants