Skip to content

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented May 13, 2025

PR Summary

This PR is a follow-up of the #25497, to clean up the [Serializable] and [OnDeserialized] attributes, as well as the EnableUnsafeBinaryFormatterSerialization property from powershell-win-core.csproj (to disable the use of BinaryFormatter).

PR Checklist

@daxian-dbw daxian-dbw requested review from a team and jshigetomi as code owners May 13, 2025 05:20
@daxian-dbw daxian-dbw added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 13, 2025
@iSazonov
Copy link
Collaborator

@daxian-dbw There are three [field: NonSerialized].

@daxian-dbw daxian-dbw requested a review from TravisEz13 May 13, 2025 19:52
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label May 21, 2025
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daxian-dbw daxian-dbw merged commit 625da6f into PowerShell:master Jun 2, 2025
48 of 52 checks passed
@daxian-dbw daxian-dbw deleted the cleanup branch June 2, 2025 22:16
@daxian-dbw daxian-dbw removed the Review - Needed The PR is being reviewed label Jun 2, 2025
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Jun 2, 2025

📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Jun 4, 2025
pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Aug 6, 2025
….Management.UI.Internal` project (PowerShell#25548)

Also removed `EnableUnsafeBinaryFormatterSerialization` property from `powershell-win-core.csproj` to disable the use of `BinaryFormatter`.
SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
….Management.UI.Internal` project (PowerShell#25548)

Also removed `EnableUnsafeBinaryFormatterSerialization` property from `powershell-win-core.csproj` to disable the use of `BinaryFormatter`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

Development

Successfully merging this pull request may close these issues.

3 participants