Skip to content

Conversation

@MartinGC94
Copy link
Contributor

PR Summary

One can use array literals to deconstruct assignments like this: $Var1, $Var2 = 1..10 where $Var1 gets the first value and $var2 gets the rest.
One can also assign variables inside ParenExpressions like this: ($Var1) = 1..10 though to my knowledge this serves no practical purpose.
This PR fixes it so variable assignments made like this are included in the completion results.

PR Context

PR Checklist

@iSazonov iSazonov requested a review from Copilot April 11, 2025 04:20
@iSazonov iSazonov self-assigned this Apr 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1: Language not supported

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Apr 11, 2025
@iSazonov
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@iSazonov iSazonov merged commit 957eb1b into PowerShell:master May 8, 2025
39 of 42 checks passed
@iSazonov iSazonov removed the Review - Needed The PR is being reviewed label May 8, 2025
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented May 8, 2025

📣 Hey @@MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants