Skip to content

Conversation

@jshigetomi
Copy link
Collaborator

@jshigetomi jshigetomi commented Apr 9, 2025

PR Summary

This pull request includes changes to the .pipelines/templates/mac-package-build.yml file, primarily focusing on updating the code signing task and improving the handling of environment variables.

Updates to Code Signing Task:

  • Replaced the SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5 task with onebranch.pipeline.signing@1 for the code signing process. This includes updating the task display name and input parameters to streamline the signing operation.

Improvements to Environment Variable Handling:

  • Modified the syntax for accessing environment variables in the Expand-Archive and New-Item commands to use $(variable) instead of $env:variable for consistency and better readability.

PR Context

PR Checklist

@jshigetomi jshigetomi marked this pull request as ready for review April 9, 2025 16:43
@jshigetomi jshigetomi requested a review from a team as a code owner April 9, 2025 16:43
@jshigetomi
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi jshigetomi added BackPort-7.4.x-Consider BackPort-7.5.x-Consider CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Apr 9, 2025
@jshigetomi jshigetomi changed the title Mac o ssigning Migrate MacOS Signing to OneBranch Apr 9, 2025
@jshigetomi
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 added the Compliance Related to compliance requirements label Apr 9, 2025
@TravisEz13 TravisEz13 merged commit f5da584 into master Apr 9, 2025
38 checks passed
@TravisEz13 TravisEz13 deleted the MacOSsigning branch April 9, 2025 21:37
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Apr 9, 2025

📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Apr 10, 2025
pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Apr 21, 2025
Sysoiev-Yurii pushed a commit to Sysoiev-Yurii/PowerShell that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Compliance Related to compliance requirements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants