-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update Devcontainer Configuration #25274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@iSazonov friendly bump, this has sat idle for 30 days. Is there a particular team/WG I should be petitioning? |
|
@TravisEz13 Is MSFT team interested in creating the development container? |
To be clear, there's nothing the team has to "create", it's already done by the dotnet team. If you are referring to the prebuilds, it's just a toggle setting on the Powershell repo, and it's optional but makes the initial startup time of the devcontainer faster. EDIT: Friendly Bump. @iSazonov and @TravisEz13 this is development tooling and does not affect the build process or anyone not using devcontainer (probably basically everyone but me 🙂), and the existing devcontainer config is way out of date and non-functional anyways, so this should be a pretty low barrier merge. |
|
@bergmeister Could you please review? |
4ee9ec5 to
ac66cf5
Compare
|
iSazonov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JustinGrote I see too many unrelated changes. Please move them to other PRs to keep the PR as small as possible.
|
@JustinGrote I have no experience working with dev containers so we need more reviewers. |
3c62181 to
be68dc3
Compare
be68dc3 to
cacde42
Compare
|
@iSazonov unrelated changes moved to PRs (the vscode task changes are relevant to the devcontainer). @jshigetomi @bergmeister request re-review. Also if there isn't a lot of interest in maintaining this section, is it possible I could be added to CODEOWNERS for it? It doesn't affect the build process in any way, it's purely developer tooling configuration. |
|
Still active. |
|
Still active |
|
Still active. |
|
Still active |
|
Still active |
PR Summary
Implements an updated devcontainer specification for quickly bootstrapping the PowerShell development environment.
Screen.Recording.2025-05-10.001357.mp4
Users can use this devcontainer locally, or develop in Github Codespaces (free minutes for Github users).
Additional Setup Necessary by PowerShell Team
As this is developer tooling only, this is a low impact/low risk PR.
Demonstration
You can test this PR by going to Codespace Creation for the upstream branch.
You can also demo a more typical user experience by:
,) on your keyboard or click + on the codespaces menuPR Context
I, as a PowerShell contributor or someone new to PowerShell development, want to at a click of a button have an environment where I can immediately start building, testing, and contributing to PowerShell, whether that is local to my own machine, in Github Codespaces, or anywhere that devcontainers are supported.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).