WIP: Add XUnit test for GetMatchingResults in CompletionHelpers class
#25184
Conversation
|
I think this method needs to be improved. For example, the RFC says that a filter can be not only like "word*", but also like "word", "*word" and so on. So perhaps we need to postpone adding tests. Perhaps we should return to the interface discussion and then come back here. |
@iSazonov I agree. We can postpone this for interface discussion. There are alot of improvements I'd like to make but probably only worth including when interface is approved. This method will explode with the many options it can support otherwise 😄. E.g For interface we'd have to also support ways of fltering |
ArmaanMcleod
changed the title
GetMatchingResults in CompletionHelpers classGetMatchingResults in CompletionHelpers class
|
📣 Hey @ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
2 participants
PR Summary
So to make sure the
GetMatchingResultsmethod in CompletionHelpers class is covered from regression, I have added tests to ensure code is covered by regressions.Similar to #25181
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).