Skip to content

Conversation

@ArmaanMcleod
Copy link
Contributor

@ArmaanMcleod ArmaanMcleod commented Mar 5, 2025

PR Summary

Follow up from #25116 (comment).

Adding dotnet_style_prefer_collection_expression to when_types_exactly_match

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0300

Background Info: dotnet/runtime#100250

PR Context

PR Checklist

@iSazonov iSazonov added the CL-NotInBuild Indicates that a PR is reverted and not part of the build. label Mar 5, 2025
@iSazonov

This comment was marked as outdated.

@iSazonov iSazonov self-assigned this Mar 5, 2025
@azure-pipelines

This comment was marked as outdated.

@iSazonov
Copy link
Collaborator

iSazonov commented Mar 5, 2025

@ArmaanMcleod Since no changes CIs don't start. Please add a dummy change in build.psm1 (ex., final dot in first comment)

    # Skips a check that prevents building PowerShell on unsupported Linux distributions

@ArmaanMcleod ArmaanMcleod requested a review from a team as a code owner March 5, 2025 09:57
@ArmaanMcleod

This comment was marked as outdated.

@iSazonov
Copy link
Collaborator

iSazonov commented Mar 5, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@iSazonov iSazonov changed the title Add dotnet_style_prefer_collection_expression to .editorconfig when types exactly match Add dotnet_style_prefer_collection_expression to .editorconfig Mar 5, 2025
@iSazonov iSazonov enabled auto-merge (squash) March 5, 2025 10:39
@iSazonov iSazonov merged commit f913924 into PowerShell:master Mar 5, 2025
42 of 45 checks passed
@iSazonov
Copy link
Collaborator

iSazonov commented Mar 5, 2025

@ArmaanMcleod Thanks!

@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Mar 5, 2025

📣 Hey @ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@iSazonov
Copy link
Collaborator

iSazonov commented Mar 5, 2025

@ArmaanMcleod I found return [] in VerbArgumentCompleter. Could you please fix this in new PR?

SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-NotInBuild Indicates that a PR is reverted and not part of the build.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants