Never load a module targeting the PSReadLine module's SessionState
#24909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
added
the
CL-General
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
iSazonov
approved these changes
Feb 1, 2025
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with one minor comment.
src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Review - Needed
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
microsoft-github-policy-service
bot
removed
the
Review - Needed
Contributor
|
📣 Hey @daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #24904
Module loading could happen in PSReadLine module's context because
But that doesn't mean the module should be loaded targeting the PSReadLine module's session state. In this case, we should use the
Globalsession state instead. PSReadLine doesn't depend on any other modules and should not have any module loaded into its session state.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed: