-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix completion of provider paths when a path returns itself instead of its children #24755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We could use a test provider from related issue and compile it with Add-Type. (There are examples in our tests, one or more is in Add-Type.Tests.ps1) |
|
Test added. I took inspiration from |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
📣 Hey @MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
PR Summary
Fixes an issue when trying to complete an item in a path as if it was a container in providers that returns the item itself when calling
Get-ChildItemon an item. This would make it complete the same item name again like this:Provider::Container1\Item1\<Tab>->Provider::Container1\Item1\Item1PR Context
Fixes #24744
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).