Update dependencies for v7.4.1 #20871

SeeminglyScience · 2023-12-08T17:25:51Z

PR Summary

Updating dependencies for release v7.4.1

PR Context

PR Checklist

SeeminglyScience · 2023-12-08T17:26:54Z

src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj


  <ItemGroup>
    <!-- This section is to force the version of non-direct dependencies -->
+    <PackageReference Include="Microsoft.Extensions.ObjectPool" Version="5.0.17" />


^ Transitive

Same question here, I wonder if this needs to be explicitly specified.

SeeminglyScience · 2023-12-08T17:27:26Z

src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj

    <PackageReference Include="System.ServiceModel.Primitives" Version="4.10.3" />
    <PackageReference Include="System.ServiceModel.Security" Version="4.10.3" />
    <PackageReference Include="System.Private.ServiceModel" Version="4.10.3" />
+    <PackageReference Include="System.Web.Services.Description" Version="4.10.3" />


^ Transitive

SeeminglyScience · 2023-12-08T17:27:56Z

....Management.Automation/SourceGenerators/PSVersionInfoGenerator/PSVersionInfoGenerator.csproj

+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" PrivateAssets="all" />
    <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" PrivateAssets="all" />
+    <!-- This section is to force the version of non-direct dependencies -->
+    <PackageReference Include="Microsoft.NETCore.Platforms" Version="1.1.2" />


^ Transitive

SeeminglyScience · 2023-12-08T17:28:36Z

src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj

-    <PackageReference Include="JsonSchema.Net" Version="5.2.6" />
+    <PackageReference Include="JsonSchema.Net" Version="5.2.7" />
+    <!-- This section is to force the version of non-direct dependencies -->
+    <PackageReference Include="Json.More.Net" Version="1.9.2" />


^ Transitive

If we didn't add this transitive package in the GA release, why do we need to add it now?

daxian-dbw · 2023-12-08T17:46:11Z

src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj

-    <PackageReference Include="JsonSchema.Net" Version="5.2.6" />
+    <PackageReference Include="JsonSchema.Net" Version="5.2.7" />
+    <!-- This section is to force the version of non-direct dependencies -->
+    <PackageReference Include="Json.More.Net" Version="1.9.2" />


If we didn't add this transitive package in the GA release, why do we need to add it now?

daxian-dbw · 2023-12-08T17:48:24Z

src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj


  <ItemGroup>
    <!-- This section is to force the version of non-direct dependencies -->
+    <PackageReference Include="Microsoft.Extensions.ObjectPool" Version="5.0.17" />


Same question here, I wonder if this needs to be explicitly specified.

daxian-dbw · 2023-12-08T17:48:45Z

src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj

    <PackageReference Include="System.ServiceModel.Primitives" Version="4.10.3" />
    <PackageReference Include="System.ServiceModel.Security" Version="4.10.3" />
    <PackageReference Include="System.Private.ServiceModel" Version="4.10.3" />
+    <PackageReference Include="System.Web.Services.Description" Version="4.10.3" />


daxian-dbw · 2023-12-08T17:48:55Z

....Management.Automation/SourceGenerators/PSVersionInfoGenerator/PSVersionInfoGenerator.csproj

+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" PrivateAssets="all" />
    <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" PrivateAssets="all" />
+    <!-- This section is to force the version of non-direct dependencies -->
+    <PackageReference Include="Microsoft.NETCore.Platforms" Version="1.1.2" />


daxian-dbw · 2023-12-08T17:53:49Z

test/xUnit/xUnit.tests.csproj


  <ItemGroup>
-    <PackageReference Include="xunit" Version="2.5.0" />
+    <PackageReference Include="xunit" Version="2.5.3" />


Moving to 2.5.3 causes xUnit test to fail. I didn't look closely and thus not sure why.

daxian-dbw · 2023-12-08T17:54:25Z

test/xUnit/xUnit.tests.csproj

+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>


Why is this needed?

pull-request-quantifier-deprecated · 2023-12-08T18:05:19Z

This PR has 10 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +5 -5
Percentile : 4%

Total files changed: 4

Change summary by file extension:
.csproj : +5 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

daxian-dbw

LGTM!

daxian-dbw · 2023-12-08T19:19:14Z

The markdown link test failure is not related to the changes in this PR.

Update dependencies for v7.4.1

2b1eede

SeeminglyScience requested review from TravisEz13, adityapatwardhan, anmenaga and daxian-dbw as code owners December 8, 2023 17:25

SeeminglyScience commented Dec 8, 2023

View reviewed changes

pull-request-quantifier-deprecated bot added the Extra Small label Dec 8, 2023

Revert unlisted prerelease verison

52f096a

daxian-dbw reviewed Dec 8, 2023

View reviewed changes

Address PR feedback

f762e8b

daxian-dbw approved these changes Dec 8, 2023

View reviewed changes

daxian-dbw merged commit ba7a7da into PowerShell:release/v7.4.1 Dec 8, 2023

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 9, 2023

iSazonov assigned daxian-dbw Dec 9, 2023

jshigetomi mentioned this pull request Jan 21, 2025

Fix backport issues with release pipeline #24835

Merged

21 tasks

		<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
		<PrivateAssets>all</PrivateAssets>

Update dependencies for v7.4.1 #20871

Update dependencies for v7.4.1 #20871

Uh oh!

Conversation

SeeminglyScience commented Dec 8, 2023

PR Summary

PR Context

PR Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pull-request-quantifier-deprecated bot commented Dec 8, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

daxian-dbw left a comment

Choose a reason for hiding this comment

Uh oh!

daxian-dbw commented Dec 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants