Skip to content

Update package fallback list for ubuntu (from those updated for ubuntu 22.04) (deb) - #17180

Merged
Travis Plunk (TravisEz13) merged 3 commits into
PowerShell:masterfrom
anamnavi:add-ubuntu22-packages
Apr 25, 2022
Merged

Update package fallback list for ubuntu (from those updated for ubuntu 22.04) (deb)#17180
Travis Plunk (TravisEz13) merged 3 commits into
PowerShell:masterfrom
anamnavi:add-ubuntu22-packages

Conversation

@anamnavi

@anamnavi Anam Navied (anamnavi) commented Apr 22, 2022

Copy link
Copy Markdown
Member

PR Summary

Add updated package dependency for libicu, liblttng-ust for ubuntu (ubuntu22.04 specifically)

PR Context

PR Checklist

Comment thread tools/packaging/packaging.psm1 Outdated
Comment thread tools/packaging/packaging.psm1 Outdated
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.psm1 : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13
Travis Plunk (TravisEz13) enabled auto-merge (squash) April 25, 2022 17:25
@TravisEz13
Travis Plunk (TravisEz13) merged commit ad5a6ff into PowerShell:master Apr 25, 2022
@TravisEz13 Travis Plunk (TravisEz13) added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log BackPort-7.0.x-Consider and removed Backport-7.2.x-Consider labels Apr 25, 2022
@TravisEz13

Copy link
Copy Markdown
Member

/backport to release/v7.2.4

@github-actions

github-actions Bot commented Apr 28, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/v7.2.4: https://github.com/PowerShell/PowerShell/actions/runs/2242323106

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@TravisEz13

Copy link
Copy Markdown
Member

removed 7.0 as .NET 5.0 and earlier does not support libssl3

@ghost

Copy link
Copy Markdown

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants