-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Remove support for AppExeCLinks to retrieve target #16044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is IO_REPARSE_TAG_APPEXECLINK const itself public? I think we could add this to docs so that exclude requests from users. |
|
Rather than a blank target, maybe we could insert a token such as |
|
Really there can be many reparse point tags for which .Net API return null target. So I think it is better to follow .Net API behavior. See also dotnet/runtime#58233 (comment) |
|
@iSazonov that const is in winnt.h: |
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🎉 Handy links: |
|
The side effect of this change is that one can no longer determine the |

PR Summary
Remove use of undocumented APIs for AppExeCLinks. Per AppX team, they have no intent of publishing structure and says users should not directly work with the target.
New behavior which seems acceptable:
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).