Skip to content

Refactor reparse tag checks #10431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 3 commits into from
Sep 17, 2019
Merged

Refactor reparse tag checks #10431

iSazonov merged 3 commits into from
Sep 17, 2019

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Aug 23, 2019 •
edited
Loading

PR Summary

Reparse tag consts is absolute numbers, not flags so we should use a comparison instead of bit operations

PR Context

PR Checklist

@iSazonov iSazonov added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Aug 23, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.4 milestone Aug 23, 2019
@iSazonov iSazonov requested a review from SteveL-MSFT August 23, 2019 07:08
@iSazonov iSazonov requested a review from anmenaga as a code owner August 23, 2019 07:08
@iSazonov iSazonov self-assigned this Aug 23, 2019
@iSazonov iSazonov mentioned this pull request Aug 23, 2019
Merged
14 tasks
@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Aug 23, 2019

@iSazonov did you test this manually for both OneDrive and AppX links?

@iSazonov
Copy link
Collaborator Author

iSazonov commented Aug 25, 2019 •
edited by unfurl-links bot
Loading

@SteveL-MSFT I found a definition for name surrogate bit https://docs.microsoft.com/en-us/windows/win32/fileio/reparse-point-tags
So using 0x20000000 constant is correct and I reverted the change.
Now only comments is updated and fixed IO_REPARSE_TAG_APPEXECLINK comparison.

Each reparse point has an identifier tag so that you can efficiently differentiate between the different types of reparse points, without having to examine the user-defined data in the reparse point.

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Aug 29, 2019

@iSazonov did you confirm it works with OneDrive and AppX links?

@iSazonov
Copy link
Collaborator Author

iSazonov commented Aug 30, 2019

@SteveL-MSFT I can confirm only for AppX - I haven't OneDrive.

@iSazonov
Copy link
Collaborator Author

iSazonov commented Sep 16, 2019

@SteveL-MSFT Have you still any thoughts about the PR?

SteveL-MSFT
SteveL-MSFT approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built your branch and tested it, looks good

@iSazonov iSazonov merged commit 79e80a8 into PowerShell:master Sep 17, 2019
@iSazonov iSazonov deleted the refactor-reparse-tag-checks branch September 17, 2019 05:48
@ghost
Copy link

ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@iSazonov iSazonov

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.5

Development

Successfully merging this pull request may close these issues.

3 participants

@iSazonov @SteveL-MSFT @TravisEz13