-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Can we remove workflow code from PowerShell Core? #9570
Copy link
Copy link
Closed
Labels
Committee-ReviewedPS-Committee has reviewed this and made a decisionPS-Committee has reviewed this and made a decisionIssue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aResolution-FixedThe issue is fixed.The issue is fixed.
Metadata
Metadata
Assignees
Labels
Committee-ReviewedPS-Committee has reviewed this and made a decisionPS-Committee has reviewed this and made a decisionIssue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aResolution-FixedThe issue is fixed.The issue is fixed.
ActionPreference.Suspendis not supported in PowerShell Core (it's only used for workflows, which are not in PowerShell Core). Today it just adds confusion to the code with checks to ensure that value isn't used where there doesn't need to be any. The checks should also be performed by a PSSA rule rather than in source code (similar toActionPreference.Ignore, as was decided in #4348). Do we need to keepActionPreference.Suspendchecks around at this point or can we just remove the half-dozen checks related to it from the source code?Further, if we remove these checks (for the same reason we removed the checks for
ActionPreference.Ignore), do we need theActionPreference.Suspendenumeration value kept around at all?@SteveL-MSFT: For committee review.
[Update]
As per the committee review, all workflow code should be removed. Here is the list of items requiring removal: