-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Open
Labels
Needs-TriageThe issue is new and needs to be triaged by a work group.The issue is new and needs to be triaged by a work group.
Description
Prerequisites
- Write a descriptive title.
- Make sure you are able to repro it on the latest released version
- Search the existing issues.
- Refer to the FAQ.
- Refer to Differences between Windows PowerShell 5.1 and PowerShell.
Steps to reproduce
When submitting a PR there are some tests which are currently only sometimes passing and can potentially fail. This is incredibly frustrating for people submitting PRs because it looks like your PR is failing and could give a false impression that the PR is breaking something when it isn't or is not ready for review. It is also only possible to close and reopen your PR which runs the whole test suite again which could then encounter another flaky test and just wastes time to run.
Either these tests should be fixed up so they can run consistently without failure or skipped/removed because a sometimes failing test is worse than no test at all.
Three tests that I've consistently come across as flaky are:
- Test-Connection.MTUSizeDetect.MTUSizeDetect works - https://dev.azure.com/powershell/PowerShell/_build/results?buildId=145814&view=ms.vss-test-web.build-test-results-tab&runId=2175688&resultId=107348&paneView=debug
Value cannot be null. (Parameter 'replyResult')
at <ScriptBlock>, /Users/runner/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 274
274: $result = Test-Connection $testAddress -MtuSize
- Clipboard cmdlet tests.Text.Get-Clipboard returns what is in Set-Clipboard - https://dev.azure.com/powershell/PowerShell/_build/results?buildId=145814&view=ms.vss-test-web.build-test-results-tab&runId=2175688&resultId=107348&paneView=debug
Process must exit before requested information can be determined.
at <ScriptBlock>, /Users/runner/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Clipboard.Tests.ps1: line 21
21: Set-Clipboard -Value $guid
- Group policy settings tests.Group policy settings tests.Module logging policy test - https://dev.azure.com/powershell/PowerShell/_build/results?buildId=145862&view=ms.vss-test-web.build-test-results-tab&runId=2175951&resultId=100001&paneView=debug
Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Basic\GroupPolicySettings.Tests.ps1: line 94
94: Should -BeTrue
Expected behavior
Tests pass consistentlyActual behavior
Some tests failError details
No response
Environment data
CIVisuals
No response
MartinGC94 and ArmaanMcleod
Metadata
Metadata
Assignees
Labels
Needs-TriageThe issue is new and needs to be triaged by a work group.The issue is new and needs to be triaged by a work group.