Working on it, should have something ready soon.

I'm really not a fan of reading ${directorySeparatorChar} all over the place, so I'm doing that a different way. In most places, I'm just using / instead of \ (if it works fine on Windows anyway), and in some cases, using a new proxy function of Join-Path with nicer syntax for joining multiple path parts, like so:

<#
    The "Ex" naming is stupid; I just want something to make it clear in the calls to this function that it's _not_
    the original Join-Path cmdlet (and doesn't need to be guarded with $SafeCommands.)

    The difference is that ChildPath is now an array with ValueFromRemainingArguments defined, so we can do this:

    Join-PathEx One Two Three Four Five

    However, we've removed pipeline input support from the ChildPath parameter, as a tradeoff.
#>
function Join-PathEx
{
    [CmdletBinding()]
    param(
        [Parameter(Mandatory = $true, Position = 0, ValueFromPipeline = $true, ValueFromPipelineByPropertyName = $true)]
        [Alias('PSPath')]
        [string[]]
        ${Path},

        [Parameter(Mandatory = $true, Position = 1, ValueFromRemainingArguments = $true)]
        [AllowEmptyString()]
        [AllowNull()]
        [string[]]
        ${ChildPath},

        [switch]
        ${Resolve},

        [Parameter(ValueFromPipelineByPropertyName = $true)]
        [pscredential]
        [System.Management.Automation.CredentialAttribute()]
        ${Credential}
    )

    begin
    {
        $null = $PSBoundParameters.Remove('Path')
        $null = $PSBoundParameters.Remove('ChildPath')

        $combinedChildPath = ''

        if ($ChildPath.Count -gt 0)
        {
            $combinedChildPath = $ChildPath[0]

            for ($i = 1; $i -lt $ChildPath.Count; $i++)
            {
                $combinedChildPath = & $SafeCommands['Join-Path'] -Path $combinedChildPath -ChildPath $ChildPath[$i] @PSBoundParameters
            }
        }
    }

    process
    {
        $null = $PSBoundParameters.Remove('Path')
        $null = $PSBoundParameters.Remove('ChildPath')

        foreach ($p in $Path)
        {
            & $SafeCommands['Join-Path'] -Path $p -ChildPath $combinedChildPath @PSBoundParameters
        }
    }
}

    Describe 'Stripping common parent paths' {
        $paths = @(
            Join-PathEx C: Common Folder UniqueSubFolder1 File.ps1
            Join-PathEx C: Common Folder UniqueSubFolder2 File2.ps1
            Join-PathEx C: Common Folder UniqueSubFolder3 File3.ps1
        )

        $commonPath = Get-CommonParentPath -Path $paths
        $expectedCommonPath = Join-PathEx C: Common Folder

        It 'Identifies the correct parent path' {
            $commonPath | Should Be $expectedCommonPath
        }

        $expectedRelativePath = Join-PathEx UniqueSubfolder1 File.ps1

        It 'Strips the common path correctly' {
            Get-RelativePath -Path $paths[0] -RelativeTo $commonPath |
            Should Be $expectedRelativePath
        }
    }

Replace Pester submodule with import #1371

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions