Tab completion doesn't show files whose names differ from others by case only#3456
Conversation
|
Can I get some help with tests? I wrote a quick failing test with |
99ef5ec to
75a9787
Compare
|
The I updated the code to get rid of |
Good catch, thanks. There is a better pattern to do it on the fly though: for (int i = 0; i < collection.Length; i++) {
if (predicate(collection[i])) {
// postdec cancels out increment, so next loop still uses same index
collection.RemoveAt(i--);
}
}I personally like it as it's compact and efficient, other people find it hacky. Up to you. |
|
🎉 |
PR Summary
Fixes #3455
Remove case-insensitive comparator from suggestion deduplication logic. Unnecessary
ToArray()removed in neighboring line to improve performance.PR Checklist
Microsoft Reviewers: Open in CodeFlow