Skip to content

Feat: add support for upcasing, downcasing, and capitalizing word#3365

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
3N4N:feat/casing
Jul 18, 2022
Merged

Feat: add support for upcasing, downcasing, and capitalizing word#3365
daxian-dbw merged 2 commits intoPowerShell:masterfrom
3N4N:feat/casing

Conversation

@3N4N
Copy link
Contributor

@3N4N 3N4N commented Jul 2, 2022 •
edited
Loading

PR Summary

Closes #2912

GNU Readline provides functionalities which let the user change the case of the word in front of the cursor. They can change the word to upper case or lower case, or they can capitalize it. The keybindings by default provided are as follows.

bind '"\ec": capitalize-word'    # default is alt-c
bind '"\eu": upcase-word'     # default is alt-u
bind '"\el": downcase-word'  # default is alt-l

This PR brings that functionality to PSReadLine.

The newly added bindable functions are in the "Basic editing functions" section:

  • CapitalizeWord, bound to Alt+c and Escape,c in Emacs mode
  • DowncaseWord, bound to Alt+l and Escape,l in Emacs mode
  • UpcaseWord, bound to Alt+u and Escape,u in Emacs mode

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in
    • conhost.exe (with MockPSConsole)
    • Windows Terminal (with MockPSConsole)
    • Visual Studio Code Integrated Terminal
  • User-facing changes
Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jul 2, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@3N4N
Copy link
Contributor Author

3N4N commented Jul 2, 2022

@lzybkr Hi, again. Some of the requirements have not been fulfilled (writing tests, adding docs). I need help with that. And being unfamiliar with the codebase, what I've come up with must be riddled with bugs. Need review on the actual code, too. You understand.

@lzybkr lzybkr requested a review from daxian-dbw July 5, 2022 18:05
@lzybkr
Copy link
Contributor

lzybkr commented Jul 5, 2022

@3N4N - thanks for the contribution - @daxian-dbw is the PSReadLine maintainer now.

@3N4N
Copy link
Contributor Author

3N4N commented Jul 8, 2022

Any chance of it getting reviewed? An update would be nice.

@daxian-dbw
Copy link
Member

daxian-dbw commented Jul 8, 2022

@3N4N thanks for submitting the PR, we will review it the next Monday. Every Monday is our community day, where we focus on PRs and issues.

@3N4N
Copy link
Contributor Author

3N4N commented Jul 8, 2022

Thanks.

daxian-dbw
daxian-dbw requested changes Jul 12, 2022
View reviewed changes
@3N4N 3N4N force-pushed the feat/casing branch 2 times, most recently from ac0734d to baef10d Compare July 12, 2022 15:02
@3N4N
Copy link
Contributor Author

3N4N commented Jul 12, 2022

All suggestions except the tests have been committed. I'll get to the tests soon.

@3N4N
Copy link
Contributor Author

3N4N commented Jul 13, 2022

@daxian-dbw All suggestions committed. Tests for all three functions added.

@3N4N 3N4N requested a review from daxian-dbw July 15, 2022 17:49
daxian-dbw
daxian-dbw approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I pushed a commit to fix up a few minor issues, and also added descriptions for the new public functions.

@daxian-dbw daxian-dbw merged commit 6808c18 into PowerShell:master Jul 18, 2022
@3N4N
Copy link
Contributor Author

3N4N commented Jul 18, 2022

Thanks @daxian-dbw for the merge.

@daxian-dbw daxian-dbw mentioned this pull request Jul 18, 2022
Closed
2 tasks
sdwheeler
sdwheeler reviewed Jul 18, 2022
View reviewed changes
michaeltlombardi added a commit to michaeltlombardi/PowerShellDocs that referenced this pull request Jul 18, 2022
@michaeltlombardi
(MicrosoftDocsGH-9033) Add casing functions for PSReadLine 2.3.0
88771d6 
The change in PowerShell/PSReadLine#3365 added three new functions for
modifying the casing of text with PSReadLine. This change:

- Adds an entry for each new function in the "Basic editing functions"
  section of `about_PSReadLine_Functions.md`
- Resolves MicrosoftDocs#9033
- Resolves AB#4387
@michaeltlombardi michaeltlombardi mentioned this pull request Jul 18, 2022
Merged
4 tasks
sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Jul 19, 2022
@michaeltlombardi
(GH-9033) Add casing functions for PSReadLine 2.3.0 (#9035)
b6b9fda 
The change in PowerShell/PSReadLine#3365 added three new functions for
modifying the casing of text with PSReadLine. This change:

- Adds an entry for each new function in the "Basic editing functions"
  section of `about_PSReadLine_Functions.md`
- Resolves #9033
- Resolves AB#4387
@3N4N 3N4N deleted the feat/casing branch July 22, 2022 04:48
@ghost
Copy link

ghost commented Mar 8, 2023

🎉 v2.3.0-beta0 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

+2 more reviewers

@lzybkr lzybkr lzybkr left review comments

@sdwheeler sdwheeler sdwheeler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for capitalizing, upcasing, and downcasing words

4 participants

@3N4N @lzybkr @daxian-dbw @sdwheeler