This repository was archived by the owner on Feb 24, 2021. It is now read-only.
DscResource.Template: Update the integrate test template#15
Merged
gaelcolas merged 2 commits intoPowerShell:masterfrom Mar 22, 2019
Merged
DscResource.Template: Update the integrate test template#15gaelcolas merged 2 commits intoPowerShell:masterfrom
gaelcolas merged 2 commits intoPowerShell:masterfrom
Conversation
- Update the integrate test `'Should return $true when Test-DscConfiguration is run'` that did not fail correctly if `Test-DscConfiguration` returned 'False' (issue PowerShell#14). - Updated some comments in files that wrongly referenced a non-existent module.
gaelcolas
approved these changes
Mar 21, 2019
gaelcolas
left a comment
gaelcolas
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johlju)
Tests/Integration/MSFT_Folder.Integration.Tests.ps1, line 39 at r1 (raw file):
Describe "$($script:dscResourceName)_Integration" { BeforeAll { $resourceId = "[$($script:dscResourceFriendlyName)]Integration_Test"
It's ok, but I wanna chat to you about this before merging ;)
gaelcolas
approved these changes
Mar 22, 2019
gaelcolas
left a comment
gaelcolas
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
'Should return $true when Test-DscConfiguration is run'that did not fail correctly ifTest-DscConfigurationreturned 'False' (issue Integration test 'Should return $true when Test-DscConfiguration is run' does not fail #14).module.
This Pull Request (PR) fixes the following issues
Task list
This change is