fix: bring latest_migrations.manifest up to date#9525
Merged
Conversation
Twixes
approved these changes
Apr 26, 2022
Contributor
|
Do you know how we ended up in this state? 🤔 |
Member
Author
@neilkakkar I don't... The last two migrations were mine #9497 and #9501. Neither has the latest_migrations.manifest file in them... I didn't purposefully exclude that file but I did migrate backwards and forwards over and over again testing both of them e.g. Perhaps it was that... |
fuziontech
added a commit
that referenced
this pull request
Apr 28, 2022
* master: (137 commits) feat(cohorts): add cohort filter grammars (#9540) feat(cohorts): Backwards compatibility of groups and properties (#9462) perf(ingestion): unsubscribe from buffer topic while no events are produced to it (#9556) fix: Fix `Loading` positioning and `LemonButton` disabled state (#9554) test: Speed up backend tests (#9289) fix: LemonSpacer -> LemonDivider (#9549) feat(funnels): Highlight significant deviations in new funnel viz (#9536) docs(storybook): Lemon UI (#9426) feat: add support for list of teams to enable the conversion buffer for (#9542) chore(onboarding): cleanup framework grid experiment (#9527) fix(signup): domain provisioning on cloud (#9515) chore: split out async migrations ci (#9539) feat(ingestion): enable json ingestion for self-hosted by default (#9448) feat(cohort): add all cohort filter selectors to Storybook (#9492) feat(ingestion): conversion events buffer consumer (#9432) ci(run-backend-tests): remove CH version default (#9532) feat: Add person info to events (#9404) feat(ingestion): produce to buffer partitioned by team_id:distinct_id (#9518) fix: bring latest_migrations.manifest up to date (#9525) chore: removes unused feature flag (#9529) ...
pauldambra
added a commit
that referenced
this pull request
May 13, 2022
(cherry picked from commit 7e76979)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The latest_migrations.manifest is two migrations behind. Generating a new migration chooses the correct next number and updates the latest_migration file but bring incorrect may mislead someone
Changes
Updates the latest_migration file
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
by opening this PR so that the tests will run
and by generating a new migration to check that it behaves correctly