fix: fix migration without using both sql and orm#9501
Merged
pauldambra merged 3 commits intomasterfrom Apr 25, 2022
Merged
Conversation
mariusandra
approved these changes
Apr 22, 2022
Collaborator
mariusandra
left a comment
mariusandra
left a comment
There was a problem hiding this comment.
Friday evening, go for it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
see #9497
but loading the ID using SQL and then using it to load django ORM models managed to load IDs that didn't exist by the time they were queried for
Changes
This uses the django ORM to load dashboard tiles in pages of up to 500
gathers any tiles that need to be updated and then updates those up-to 500 tiles in one operation
How did you test this code?
running the tests