Skip to content

feature(insights): many-to-many dashboards#9408

Closed
mariusandra wants to merge 51 commits intomasterfrom
many-to-many-insights-fork
Closed

feature(insights): many-to-many dashboards#9408
mariusandra wants to merge 51 commits intomasterfrom
many-to-many-insights-fork

Conversation

@mariusandra
Copy link
Copy Markdown
Collaborator

@mariusandra mariusandra commented Apr 13, 2022

Problem

Totally Work In Progress.

Continues work from #9331

Changes

  • Create an explicit DashboardTile model to store dashboard item layouts, style and relations, move layouts and color there from insights.
  • Update serializers, so that the frontend does not know any better about the backend changes.
  • Still some places to change.

How did you test this code?

  • Still ongoing

pauldambra added 30 commits April 4, 2022 13:04
@pauldambra
add a TODO on insight
e0bf95c
@pauldambra
add manytomany dashboard to insight relation
af7a0ce
@pauldambra
merge from master and update migration
5d9a120
@pauldambra
remove unnecessary change to IDE config file
72b31d5
@pauldambra
update migration to add unique constraint on posthog_dashboardinsight…
9b90c68 
… joins
@pauldambra
Merge branch 'master' into many-to-many-insights
aa88da9
@pauldambra
Add migration that pages through old dashboard item relation and copi…
c4b5d8f 
…es to new dashboard insight relation
@pauldambra
correct reverse relationship name
64230de
@pauldambra
hide the insight/item split from insight patch calls
3108ad6
@pauldambra
creating an insight with a dashboard id adds the dashboard to the man…
2270c07 
…ytomany relation
@pauldambra
make the new dashboard tests less rubbish
73939e3
@pauldambra
remove second migration
0d5d09e
@pauldambra
don't hardcode ids in tests
d55524c
@pauldambra
don't hardcode ids in tests
6df5af8
@pauldambra
can safely add dashboard links on create and update
29c9613
@pauldambra
write a test to show that loading a dashboard is nplus1
5538fd8
@pauldambra
make test pass and add a comment that adding insights to dashboards _…
9e3a592 
…is_ n+1
@pauldambra
dashboard does not show soft deleted insights
ff45451
@pauldambra
skip test instead of having incorrect assertion
424cf90
@pauldambra
start refactoring insight tests
6229e92
@pauldambra
Merge branch 'master' into many-to-many-insights
e8484cd
@pauldambra
more test refactoring and reduce insight loading from 13 to 9 queries
b272c6f
@pauldambra
move all insight tests to creating insights through the API not the ORM
d6ca343
@pauldambra
use splats not pipes because mypy
dcb5bd1
@pauldambra
collapse prefetch and select related
a5a72f9
@pauldambra
dashboard permissions propogated through new relation
48818f4
@pauldambra
check permissions on old and new relation
7c7635f
@pauldambra
no longer makes sense for insight basic serializer to try and grab fi…
64417ac 
…lters from a single dashboard
@pauldambra
satisfy typechecker
56ca708
@pauldambra
deal with caching WIP
eb49426
pauldambra and others added 21 commits April 6, 2022 22:41
@pauldambra
a pass at dashboard+insight specific filter hashes
8cc0bb5
@pauldambra
wip
e55eb9d
@pauldambra
restrict but don't flatten the number of queries to load a dashboard …
f1b1c74 
…after connecting dashboards and insights
@pauldambra
correctly dedupe and update insights
a71cc83
@pauldambra
fix cache test
1602e40
@pauldambra
raise validation error on illegal dashboard link
3aecf21
@pauldambra
make insight to representation dashboard aware filtering work
f00b479
@pauldambra
team id in test needs to be consistent
ce2567e
@pauldambra
fix insight patching behaviour
5a37d01
@pauldambra
better linking between dashboard and insight
e1b2100
@pauldambra
convert to many-to-many without manual through table - WIP
2d1ba56
@pauldambra
works but never writes to the cache
4d3b57c
@pauldambra
resolve nplus1 test
8dc7086
@pauldambra
cache key WIP
ba7af95
@pauldambra
WIP
eddb23b
@pauldambra
improvements to keeping dashboard and dashboards in sync
9baa3de
@pauldambra
add comment with todo to update_cache
1879647
@pauldambra
remove unnecessary todo from dashboard logic
9228e3e
@mariusandra
create explicit dashboard_insight table for many-to-many metadata
c1623d4
@mariusandra
can edit if on any editable dashboard
57fd41c
@mariusandra
create dashboard tiles
cf0797a
@mariusandra mariusandra changed the base branch from many-to-many-insights to master April 14, 2022 09:05
@mariusandra mariusandra mentioned this pull request Apr 14, 2022
Merged
@posthog-bot
Copy link
Copy Markdown
Contributor

posthog-bot commented Apr 22, 2022

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mariusandra @posthog-bot @pauldambra