Add linter rule to guide people to the right dayjs import#8156
Merged
mariusandra merged 2 commits intomasterfrom Jan 20, 2022
Merged
Add linter rule to guide people to the right dayjs import#8156mariusandra merged 2 commits intomasterfrom
mariusandra merged 2 commits intomasterfrom
Conversation
6 tasks
Collaborator
|
only... this rule now caught some old broken code. Can you update these imports as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
We have a specific DayJS import to use in
lib/dayjsHowever, on first attempting to use any DayJS code in a file, an IDE will prompt to import directly from the DayJS module.
This adds a linter rule to guide the developer to use the correct import.
How did you test this code?
Adding the rule and seeing that the linter shows an error when directly importing DayJS