Merged
Conversation
EDsCODE
reviewed
Sep 21, 2021
Contributor
Author
Based on: #4364 (comment) , decided to get rid of second operator. The difference was: One did |
pauldambra
pushed a commit
that referenced
this pull request
Sep 23, 2021
* enable paths grouping on backend * write API test for path groupings * remove % only use *
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Part of #4364
Goes after #6035
Decisions made:
*matches everything (.*regex). We don't allow custom regexes. We'll probably have to experiment to figure out what are the best operators to expose, but this seemed good enough for now.PathEventQuery. Doing things like this, start & end points respect aggregations as well, and felt cleaner than doing it in the middle, since that would involve keeping timestamps in order as well. (when 2 events become duplicates because of grouping, these effectively become duplicate events that we dedupe)Introducing the
path_groupingsAPI parameter, which takes a list of strings to match. For example, see test:posthog/ee/clickhouse/views/test/test_clickhouse_paths.py
Line 102 in 49b892b
Checklist