Merged
Conversation
neilkakkar
approved these changes
Aug 25, 2021
| ], | ||
| } | ||
| funnel_filter = Filter(data=data) | ||
| path_filter = PathFilter(data=data) |
Contributor
There was a problem hiding this comment.
This is, I think, another sign of "We should have a single filter object that works".
Although, I think your call is right here. I'd also like to finish basic Paths first, before thinking of this refactor :)
| @@ -1,5 +1,5 @@ | |||
| FUNNEL_PERSONS_BY_STEP_SQL = """ | |||
| SELECT person_id | |||
| SELECT person_id {timestamp} | |||
Contributor
There was a problem hiding this comment.
maybe this should be extra_fields ?
Can also wait till we actually have other fields, like when we get to path pinning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Please describe.
funnel_pathsfunnel_paths: True, the path data returned will be base don the funnel dropoffIf this affects the frontend, include screenshots.
Checklist